Skip to content

Add additional Room AC profiles #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add additional Room AC profiles #2013

wants to merge 1 commit into from

Conversation

nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Mar 21, 2025 •
edited
Loading

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This change adds additional Room AC profiles that exclude the thermostatOperatingState capability. Note that some other profiles are removed to stay under the limit of 100 profiles per driver.

Summary of Completed Tests

@nickolas-deboom
Remove unused profiles to stay below limit
1d55fb1 
This change removes unused profiles in favor of new Room AC profiles to
stay under the profile limit of 100. The air purifier profiles can be
restored once this limit is increased on the cloud side.
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

Channel deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

Test Results

   65 files    418 suites   0s ⏱️
2 122 tests 2 122 ✅ 0 💤 0 ❌
3 637 runs  3 637 ✅ 0 💤 0 ❌

Results for commit 1d55fb1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

File Coverage
All files 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 50% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 1d55fb1

hcarter-775
hcarter-775 requested changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@hcarter-775 hcarter-775 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I don't think we should merge this. Putting this down to remove my approval

@nickolas-deboom nickolas-deboom changed the title Remove unused profiles to stay below limit Add additional Room AC profiles Mar 21, 2025
@hcarter-775
Copy link
Contributor

should we close this PR for simplicity?

@nickolas-deboom
Copy link
Contributor Author

Closing as no longer needed with profile limit increase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcarter-775 hcarter-775 hcarter-775 requested changes

@ctowns ctowns Awaiting requested review from ctowns

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickolas-deboom @hcarter-775